Skip to content

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 26, 2022

Description of the Change

This change makes the DJA schema class compatible with the DRF change introduced with encode/django-rest-framework#7424

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 26, 2022 08:47
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought DRF had decided to stop merging schema generator changes in lieu of recommending an external library, drf-spectacular.

@n2ygk n2ygk merged commit 4e18292 into django-json-api:main Oct 26, 2022
@sliverc sliverc deleted the openapi_serializer branch October 26, 2022 14:59
@sliverc
Copy link
Member Author

sliverc commented Oct 27, 2022

Thanks for merging. This change actually got integrated 2 years ago and I have just recently stumbled upon it. There is a recent change encode/django-rest-framework#7493 which will affect DJA as well, so it seems minor changes are still merged, but nothing major.

@auvipy
Copy link
Contributor

auvipy commented Oct 27, 2022

Thanks for merging. This changed actually got integrated 2 years ago and I have just recently stumbled upon it. There is a recent change encode/django-rest-framework#7493 which will affect DJA as well, so it seems minor changes are still merged, but nothing major.

you are right, but crucial changes for thing important in DRF will also be merged. I know this from conversation with Tom Christie. DRF will deprecate core schema, but improve OpenAPI support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants