Skip to content

Make NewThreadUnsafeSet() take optional vals. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Make NewThreadUnsafeSet() take optional vals. #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ type Set[T comparable] interface {
UnmarshalJSON(b []byte) error
}

// NewSet creates and returns a reference to an empty set. Operations
// on the resulting set are thread-safe.
// NewSet creates and returns a new set with the given elements.
// Operations on the resulting set are thread-safe.
func NewSet[T comparable](vals ...T) Set[T] {
s := newThreadSafeSet[T]()
for _, item := range vals {
Expand All @@ -198,10 +198,13 @@ func NewSetFromSlice[T comparable](v []T) Set[T] {
return s
}

// NewThreadUnsafeSet creates and returns a reference to an empty set.
// NewThreadUnsafeSet creates and returns a new set with the given elements.
// Operations on the resulting set are not thread-safe.
func NewThreadUnsafeSet[T comparable]() Set[T] {
func NewThreadUnsafeSet[T comparable](vals ...T) Set[T] {
s := newThreadUnsafeSet[T]()
for _, item := range vals {
s.Add(item)
}
return &s
}

Expand Down