Skip to content

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

Resolves #4988

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Sep 17, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Sep 17, 2025
@mfranzke mfranzke linked an issue Sep 17, 2025 that may be closed by this pull request
7 tasks
Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 8b22297

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Sep 17, 2025
@mfranzke mfranzke marked this pull request as draft September 17, 2025 09:57
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Sep 17, 2025
Copy link
Contributor

@mfranzke mfranzke marked this pull request as ready for review September 17, 2025 11:29
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Sep 29, 2025
@mfranzke mfranzke changed the title refactor: removed obsolete code fix(docs): clicking the detail view link opens two new windows Sep 29, 2025
@mfranzke mfranzke enabled auto-merge (squash) September 29, 2025 15:30
@michaelmkraus michaelmkraus moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Oct 2, 2025
return '';
}

const currentUrl = globalThis.location.href.split('?');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const currentUrl = globalThis.location.href.split('?');
const [baseUrl, query=''] = globalThis.location.href.split('?');

We could use it the following lines like this instead of using the index:

const searchParameters = new URLSearchParams(query);

@michaelmkraus michaelmkraus removed their assignment Oct 2, 2025
@michaelmkraus michaelmkraus moved this from 👀 Actively In Review to 🏗 In progress in UX Engineering Team Backlog Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 📺showcases Changes to 1-n showcases
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

docs: Clicking the detail view link opens two new windows
2 participants