Skip to content

Zookeeper metrics port registration #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Zookeeper metrics port registration #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbc8641
Zookeeper metrics port registration
kamilchociej Jan 20, 2025
3ca63ed
Defaults test adjustment
kamilchociej Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../src/main/java/com/datastax/oss/kaap/controllers/zookeeper/ZooKeeperResourcesFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public class ZooKeeperResourcesFactory extends BaseResourcesFactory<ZooKeeperSpe
public static final int DEFAULT_LEADER_ELECTION_PORT = 3888;
public static final int DEFAULT_CLIENT_PORT = 2181;
public static final int DEFAULT_CLIENT_TLS_PORT = 2281;
public static final int DEFAULT_METRICS_PORT = 8000;
public static final String ENV_ZOOKEEPER_SERVERS = "ZOOKEEPER_SERVERS";
public static final List<String> DEFAULT_ENV = List.of("ZOOKEEPER_SERVERS");

Expand Down Expand Up @@ -309,6 +310,10 @@ public void patchStatefulSet() {
new ContainerPortBuilder()
.withName("leader-election")
.withContainerPort(DEFAULT_LEADER_ELECTION_PORT)
.build(),
new ContainerPortBuilder()
.withName("metrics")
.withContainerPort(DEFAULT_METRICS_PORT)
.build()
))
.withEnv(env)
Expand Down
2 changes: 2 additions & 0 deletions ...or/src/test/java/com/datastax/oss/kaap/controllers/zookeeper/ZooKeeperControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ public void testDefaults() throws Exception {
name: server
- containerPort: 3888
name: leader-election
- containerPort: 8000
name: metrics
readinessProbe:
exec:
command:
Expand Down