Skip to content

Introduced timeout in allocate_connection to prevent deadlocks #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Introduced timeout in allocate_connection to prevent deadlocks #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/cql/internal/cql_session_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,21 @@ cql::cql_session_impl_t::allocate_connection(
connection->set_keyspace(_keyspace_name);

boost::shared_future<cql_future_connection_t> shared_future = promise->shared_future();
shared_future.wait();

if (shared_future.get().error.is_err()) {

if(! shared_future.timed_wait(boost::posix_time::seconds(30))) {
decrease_connection_counter(host);
throw cql_connection_allocation_error(
("Error when connecting to host: " + host->endpoint().to_string()).c_str());
("Connection to host host: "
+ host->endpoint().to_string()
+ " timed out after 30 seconds").c_str());
connection.reset();
} else {
if (shared_future.get().error.is_err()) {
decrease_connection_counter(host);
throw cql_connection_allocation_error(
("Error when connecting to host: " + host->endpoint().to_string()).c_str());
connection.reset();
}
}

return connection;
Expand Down