[Internal] Fix tests/integration/test_dbutils.py::test_secrets
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
approved these changes
Feb 4, 2025
hectorcast-db
added a commit
that referenced
this pull request
Feb 11, 2025
### Internal Changes * Fix `tests/integration/test_dbutils.py::test_secrets` ([#884](#884)). ### API Changes: * Added `get_message_query_result_by_attachment()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service. * Added `id` field for `databricks.sdk.service.apps.App`. * Added `limit_config` field for `databricks.sdk.service.billing.UpdateBudgetPolicyRequest`. * Added `volumes` field for `databricks.sdk.service.compute.ClusterLogConf`. * Removed `review_state`, `reviews` and `runner_collaborators` fields for `databricks.sdk.service.cleanrooms.CleanRoomAssetNotebook`. OpenAPI SHA: 99f644e72261ef5ecf8d74db20f4b7a1e09723cc, Date: 2025-02-11
hectorcast-db
added a commit
that referenced
this pull request
Feb 11, 2025
* Fix `tests/integration/test_dbutils.py::test_secrets` ([#884](#884)). * Added `get_message_query_result_by_attachment()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service. * Added `id` field for `databricks.sdk.service.apps.App`. * Added `limit_config` field for `databricks.sdk.service.billing.UpdateBudgetPolicyRequest`. * Added `volumes` field for `databricks.sdk.service.compute.ClusterLogConf`. * Removed `review_state`, `reviews` and `runner_collaborators` fields for `databricks.sdk.service.cleanrooms.CleanRoomAssetNotebook`. OpenAPI SHA: 99f644e72261ef5ecf8d74db20f4b7a1e09723cc, Date: 2025-02-11
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
### Internal Changes * Fix `tests/integration/test_dbutils.py::test_secrets` ([#884](#884)). ### API Changes: * Added `get_message_query_result_by_attachment()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service. * Added `id` field for `databricks.sdk.service.apps.App`. * Added `limit_config` field for `databricks.sdk.service.billing.UpdateBudgetPolicyRequest`. * Added `volumes` field for `databricks.sdk.service.compute.ClusterLogConf`. * Removed `review_state`, `reviews` and `runner_collaborators` fields for `databricks.sdk.service.cleanrooms.CleanRoomAssetNotebook`. OpenAPI SHA: 99f644e72261ef5ecf8d74db20f4b7a1e09723cc, Date: 2025-02-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
tests/integration/test_dbutils.py::test_secretscurrently assumes that the principal running the test has access to all key vaults in our test workspace. This isn't necessarily the case. To alleviate this, rather than listing all secrets across all scopes, we just check that our scope is included in the list of secret scopes, and only list the secrets from our scope.How is this tested?
Integration tests will automatically run on this PR.