fix: incorrect loading of ESM based configurations #32515
Merged
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/esm_config_loading
|
| Run status |
|
| Run duration | 20m 16s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
14
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26662
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.14%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
158
|
Accessibility
97.71%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
AtofStryker
force-pushed
the
fix/esm_config_loading
branch
2 times, most recently
from
213e882 to
c72382d
Compare
AtofStryker
force-pushed
the
fix/esm_config_loading
branch
from
c72382d to
f8aed28
Compare
jennifer-shehane
approved these changes
Sep 22, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Fixes an issue where ESM based cypress configs were failing in a
requirecontext due to using ESM specific imports. To fix the surgically, we attempt torequirethe config, and if it fails, fall through to try importing the config asESM. If the first fails, we just rethrow the first error of therequire.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?