fix(backend): skip servers with failed connections in IMAP message list handler #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroky
reviewed
Sep 24, 2025
| $mailbox = Hm_IMAP_List::get_connected_mailbox($id, $this->cache); | ||
|
|
||
| if (!$mailbox || !$mailbox->authed()) { | ||
| continue; // Skip this server if connection failed |
There was a problem hiding this comment.
Can we also add a feedback msg (warning or error) that server named xyz failed to connect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task
Problem: PHP Fatal error: Call to a member function search() on bool when visiting message list pages with no IMAP servers configured.
Solution: Added error checking to skip failed mailbox connections before calling ->search() method.