-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added ForeignKey(Job) to all AttributeVal models #9612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cvat/apps/engine/migrations/0092_labeledimageattributeval_job_and_more.py
Outdated
Show resolved
Hide resolved
To update test db, you can start the test containers without the new migration ( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9612 +/- ##
===========================================
+ Coverage 71.76% 71.86% +0.09%
===========================================
Files 441 441
Lines 46286 46365 +79
Branches 3949 3960 +11
===========================================
+ Hits 33218 33319 +101
+ Misses 13068 13046 -22
🚀 New features to boost your workflow:
|
FYI: migration queries
|
|
BTW, avoid "merge" commits in PR to avoid empty diff on GitHub: https://github.com/cvat-ai/cvat/pull/9612/files |
Motivation and context
Current database schema leads to inefficient query planning on postgres side.
There are some half-working workarounds, however it seems the most reliable solution is to add new ForeignKeys(Job) to all attribute tables.
How has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.