-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added middleware to track last_activity of a user #9554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
reviewed
Jun 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9554 +/- ##
===========================================
+ Coverage 73.77% 73.79% +0.01%
===========================================
Files 448 448
Lines 46712 46729 +17
Branches 3943 3943
===========================================
+ Hits 34462 34483 +21
+ Misses 12250 12246 -4
🚀 New features to boost your workflow:
|
SpecLad
approved these changes
Jun 23, 2025
SpecLad
reviewed
Jun 23, 2025
SpecLad
reviewed
Jun 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
We need a robust way to define when user used CVAT service.
It seems
last_login
field in User model may not get updated for more than a year if user works every day and do not do any logins. It does not seem reliable. Also, different auth methods (basic, social, sso) and a lot of code around make it difficult to guarantee that this field gets updated always.Timestamps from analytics are not reliable also:
Finally, currently to find non-active users it is necessary to make many queries to the clickhouse database, so, usage report generation is much slower than with just postgres.
For me middleware with registering last activity once a day, seems the most reliable way.
How has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.