-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add dynamic field selector to actions menu #9543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9543 +/- ##
===========================================
+ Coverage 71.76% 71.86% +0.09%
===========================================
Files 441 441
Lines 46286 46357 +71
Branches 3949 3960 +11
===========================================
+ Hits 33218 33314 +96
+ Misses 13068 13043 -25
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment
Please, add CHANGELOG entry
|
Motivation and context
This PR adds additional menu component into actions menu of different resources. With dynamic selector it is now possible to edit different fields using menu.
Currently supported:
How has this been tested?
Checklist
develop
branch[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.