Skip to content

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Jun 18, 2025

Motivation and context

This PR adds additional menu component into actions menu of different resources. With dynamic selector it is now possible to edit different fields using menu.

Currently supported:

  • Assignee for task, project, job
  • State, Stage for job

selector-job-assignee

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the ui/ux label Jun 18, 2025
@klakhov klakhov marked this pull request as ready for review June 25, 2025 09:24
@klakhov klakhov requested a review from bsekachev as a code owner June 25, 2025 09:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 68.35443% with 25 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (7485d1a) to head (ae825c5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9543      +/-   ##
===========================================
+ Coverage    71.76%   71.86%   +0.09%     
===========================================
  Files          441      441              
  Lines        46286    46357      +71     
  Branches      3949     3960      +11     
===========================================
+ Hits         33218    33314      +96     
+ Misses       13068    13043      -25     
Components Coverage Δ
cvat-ui 77.70% <68.35%> (-0.05%) ⬇️
cvat-server 67.23% <ø> (+0.19%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@klakhov klakhov mentioned this pull request Jun 27, 2025
6 tasks
Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment
Please, add CHANGELOG entry

@klakhov klakhov requested a review from nmanovic as a code owner July 3, 2025 08:43
Copy link

sonarqubecloud bot commented Jul 3, 2025

@klakhov klakhov merged commit 98c53b8 into develop Jul 3, 2025
37 checks passed
@klakhov klakhov deleted the kl/add-dynamic-select branch July 3, 2025 11:31
@cvat-bot cvat-bot bot mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants