Skip to content

Conversation

rongxin-liu
Copy link
Contributor

No description provided.

@rongxin-liu
Copy link
Contributor Author

Tested with finance and movies problem sets.

@Jelleas
Copy link

Jelleas commented Oct 24, 2023

Hi Rongxin! I just ran into this issue too, would love a merge on this PR :)

Quick double check, shouldn't this one be wrapped with sqlalchemy.text() too?

cursor.execute("PRAGMA foreign_keys=ON")

@rongxin-liu
Copy link
Contributor Author

Hi Rongxin! I just ran into this issue too, would love a merge on this PR :)

Quick double check, shouldn't this one be wrapped with sqlalchemy.text() too?

cursor.execute("PRAGMA foreign_keys=ON")

Hey, here we're executing a SQL statement directly using a database cursor (sqlite3 backend), not the SQLAlchemy engine so I think this usage does not need to be or should be replaced with sqlalchemy.text().

@rongxin-liu rongxin-liu merged commit fcc8cb9 into main Oct 24, 2023
@rongxin-liu rongxin-liu deleted the SQLAlchemy-2.0 branch October 24, 2023 17:45
@Jelleas
Copy link

Jelleas commented Oct 24, 2023

🥳 thanks!

LEDMann added a commit to LEDMann/CESBooks that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants