Upgrade prometheus to v3.6.0 #7040
Open
+13,117
−1,720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Update-prometheus-to-v0.306.0
branch
from
07eff9f to
b0888d1
Compare
SungJin1212
force-pushed
the
Update-prometheus-to-v0.306.0
branch
2 times, most recently
from
c80af8a to
dffa791
Compare
yeya24
reviewed
Oct 1, 2025
| f.IntVar(&l.AlertmanagerMaxSilencesSizeBytes, "alertmanager.max-silences-size-bytes", 0, "Maximum size of individual silences that a single user can have. 0 = no limit.") | ||
|
|
||
| _ = l.NameValidationScheme.Set(model.LegacyValidation.String()) | ||
| f.Var(&l.NameValidationScheme, "validation.name-validation-scheme", fmt.Sprintf("Name validation scheme for metric names and label names, Support values are: %s.", strings.Join([]string{model.LegacyValidation.String(), model.UTF8Validation.String()}, ", "))) |
There was a problem hiding this comment.
I wonder why this is a runtime limit. Is it intended to be configurable per tenant? Where do we actually set this value
There was a problem hiding this comment.
um.. I'd like to hear what other people think about whether it should be configurable per tenant or not. WDYT?
There was a problem hiding this comment.
I think it is ok to be a per tenant runtime config. But I don't see the code where we actually set this value.
There was a problem hiding this comment.
https://github.com/cortexproject/cortex/blob/v1.19.0/pkg/distributor/distributor.go#L721
The distributor is already using per-user config. I added some e2e tests.
SungJin1212
force-pushed
the
Update-prometheus-to-v0.306.0
branch
3 times, most recently
from
25e370a to
7e83120
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Update-prometheus-to-v0.306.0
branch
from
7e83120 to
acf806f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Prometheus version to v3.6.0
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]