Skip to content

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Oct 15, 2024

Change all max-async-concurrency default values 50 to 3
it includes
-blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency
-blocks-storage.bucket-store.index-cache.redis.max-async-concurrency
-blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency
-blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency

FYI. max-async-concurrency default values of the multilevels (index, chunks) are already 3.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the storage/blocks Blocks storage engine label Oct 15, 2024
@harry671003
Copy link
Contributor

Could you help me understand why the defaults are changed from 50 to 3?

@SungJin1212
Copy link
Member Author

@harry671003
50 goroutines taking a lot of CPUs as mentioned (comment) in #6249.
And I got the comment to change all async concurrency in #6265.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@SungJin1212
Copy link
Member Author

@yeya24
Could you take review it ?

@yeya24 yeya24 merged commit e3b4ef8 into cortexproject:master Nov 4, 2024
16 checks passed
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size/M storage/blocks Blocks storage engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants