Skip to content

Conversation

ElliottAYoung
Copy link
Contributor

@toastercup @arelia @MKwenhua

Adds the empty class for ContentItemFieldTypes (only empty for now) and allows for this button to link to the necessary classes to trigger the media popup in Cortex.

Copy link
Contributor

@MKwenhua MKwenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

%button.content_item_button.text-center.popup--open

to:

 .content_item_button.text-center.popup--open

that way you wont need to prevent default and it will wont fire any native browser events.

@toastercup
Copy link
Member

@MKwenhua @ElliottAYoung That suggestion defies the use of semantic elements, however - this is a button and should remain a button, IMO. We shouldn't need to preventDefault here because there is no form action associated with this button, nor any other default browser event.

@toastercup
Copy link
Member

@ElliottAYoung Remember that the PR naming conventions specify a capitalized title. This is nitpicky, so historically I've gone through and corrected your PRs, but since it's been a recurring thing, I wanted to mention it - esp. if Cortex is going to be open source, we should present a unified standard that all contributors will be held to

@toastercup toastercup changed the title COR-526: popup button COR-526: Popup utton Dec 15, 2016
@toastercup toastercup changed the title COR-526: Popup utton COR-526: Popup Button Dec 15, 2016
Copy link
Contributor

@MKwenhua MKwenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I agree with @toastercup , no need to change the button tag :neckbeard:

@ElliottAYoung ElliottAYoung merged commit 9012236 into develop Dec 15, 2016
@ElliottAYoung ElliottAYoung deleted the topic/COR-526-Popup-Button branch December 15, 2016 15:23
@toastercup
Copy link
Member

@ElliottAYoung FYI for the future, remember to bump the version once you've wrapped up a feature, otherwise it breaks Cortex develop. As maintainers of this lib, we can bump version within a PR, but contributors do not bump version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants