Skip to content

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 9, 2025

Summary by Sourcery

Chores:

  • Update version references to 0.12.2 across documentation, man pages, RPM spec, pyproject.toml, and version.py

Copy link
Contributor

sourcery-ai bot commented Sep 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the project version from 0.12.1 to 0.12.2 by bumping version strings in documentation, packaging metadata, and source code.

File-Level Changes

Change Details Files
Bumped version references in documentation
  • Updated usage example in version manpage
  • Updated default image tag description in all command manpages
docs/ramalama-version.1.md
docs/ramalama-bench.1.md
docs/ramalama-perplexity.1.md
docs/ramalama-rag.1.md
docs/ramalama-run.1.md
docs/ramalama-serve.1.md
Updated RPM spec metadata
  • Bumped global version0 macro
  • Adjusted Obsoletes requirement to new version
rpm/ramalama.spec
Updated project metadata in pyproject.toml
  • Set version field to 0.12.2
pyproject.toml
Updated runtime version function
  • Changed return value of version() to 0.12.2
ramalama/version.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's declared version to "0.12.2". This is a routine maintenance change to ensure all internal and external references to the software version are consistent with the latest release.

Highlights

  • Version Update: The project version has been updated from "0.12.1" to "0.12.2" across all relevant configuration and source files.
  • Documentation Alignment: All user-facing documentation files have been updated to reflect the new "0.12.2" version number.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the project version to 0.12.2 across all relevant files. The changes are consistent and look good.

I've added a couple of suggestions to improve maintainability for future version bumps. By establishing a single source of truth for the version number (e.g., in ramalama/version.py), you can simplify the release process and reduce the risk of inconsistencies. This would also simplify the newver.sh script, as it would only need to update a single file.

pyproject.toml Outdated
[project]
name = "ramalama"
version = "0.12.1"
version = "0.12.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and establish a single source of truth for the project's version, consider configuring pyproject.toml to dynamically read the version from ramalama/version.py. This avoids the need to update the version in multiple files during a release.

You can achieve this by making the following changes:

  1. In the [project] section, replace the static version with a dynamic one:

    [project]
    name = "ramalama"
    dynamic = ["version"]
    ...
  2. Add a [tool.setuptools.dynamic] section to tell setuptools where to find the version:

    [tool.setuptools.dynamic]
    version = {attr = "ramalama.version.version"}

This would make ramalama/version.py the canonical source for the version.

%global forgeurl https://github.com/containers/%{pypi_name}
# see ramalama/version.py
%global version0 0.12.1
%global version0 0.12.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on the preceding line correctly identifies ramalama/version.py as the source of truth for the version. To improve maintainability and prevent inconsistencies, you could read the version dynamically from that file instead of hardcoding it here.

This would ensure that the RPM spec is always in sync with the project's actual version, simplifying the release process.

@rhatdan rhatdan force-pushed the VERSION branch 3 times, most recently from fd425ef to d5904ae Compare September 9, 2025 15:43
@rhatdan
Copy link
Member Author

rhatdan commented Sep 10, 2025

@mikebonnet PTAL and merge since Konflux seems to be done.

Signed-off-by: Daniel J Walsh <[email protected]>
@mikebonnet mikebonnet merged commit edb1292 into containers:main Sep 10, 2025
38 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants