-
Notifications
You must be signed in to change notification settings - Fork 261
Bump to v0.12.2 #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.12.2 #1912
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the project version from 0.12.1 to 0.12.2 by bumping version strings in documentation, packaging metadata, and source code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rhatdan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's declared version to "0.12.2". This is a routine maintenance change to ensure all internal and external references to the software version are consistent with the latest release.
Highlights
- Version Update: The project version has been updated from "0.12.1" to "0.12.2" across all relevant configuration and source files.
- Documentation Alignment: All user-facing documentation files have been updated to reflect the new "0.12.2" version number.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the project version to 0.12.2 across all relevant files. The changes are consistent and look good.
I've added a couple of suggestions to improve maintainability for future version bumps. By establishing a single source of truth for the version number (e.g., in ramalama/version.py
), you can simplify the release process and reduce the risk of inconsistencies. This would also simplify the newver.sh
script, as it would only need to update a single file.
pyproject.toml
Outdated
[project] | ||
name = "ramalama" | ||
version = "0.12.1" | ||
version = "0.12.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and establish a single source of truth for the project's version, consider configuring pyproject.toml
to dynamically read the version from ramalama/version.py
. This avoids the need to update the version in multiple files during a release.
You can achieve this by making the following changes:
-
In the
[project]
section, replace the static version with a dynamic one:[project] name = "ramalama" dynamic = ["version"] ...
-
Add a
[tool.setuptools.dynamic]
section to tellsetuptools
where to find the version:[tool.setuptools.dynamic] version = {attr = "ramalama.version.version"}
This would make ramalama/version.py
the canonical source for the version.
%global forgeurl https://github.com/containers/%{pypi_name} | ||
# see ramalama/version.py | ||
%global version0 0.12.1 | ||
%global version0 0.12.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on the preceding line correctly identifies ramalama/version.py
as the source of truth for the version. To improve maintainability and prevent inconsistencies, you could read the version dynamically from that file instead of hardcoding it here.
This would ensure that the RPM spec is always in sync with the project's actual version, simplifying the release process.
fd425ef
to
d5904ae
Compare
@mikebonnet PTAL and merge since Konflux seems to be done. |
Signed-off-by: Daniel J Walsh <[email protected]>
Summary by Sourcery
Chores: