tests: generate tmpdir store for ollama pull testcase

[booxter]

Two reasons to do so:

1. The directory is cleaned up on test completed;

2. The hardcoded directory may not be available for write to the current
   process (because some other process is running the test suite in
   parallel, or because someone chmod -rwx the directory for some
   reason).

In which case the test case fails with:
PermissionError: [Errno 13] Permission denied: '/tmp/ramalama/store'

This failure was triggered in nixpkgs CI:
https://hydra.nixos.org/build/305125672

Summary by Sourcery

Tests:

• Update the args fixture in test_ollama to create a temporary store directory using tempfile.TemporaryDirectory

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the ollama pull test to generate and use a temporary store directory via pytest fixture, ensuring write-permission and automatic cleanup.

File-Level Changes

Change	Details	Files
Switch test fixture to use a temporary directory for the store	Introduce tempfile.TemporaryDirectory context in fixture Replace hardcoded "/tmp/ramalama/store" with generated tmpdir Yield StoreArgs(store=tmpdir, engine="podman", container=True) inside context	test/unit/test_ollama.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @booxter, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and reliability of the Ollama pull test by transitioning from a fixed, hardcoded temporary directory to a dynamically created one. This change specifically addresses PermissionError issues encountered in CI environments due to potential permission conflicts or parallel test runs, ensuring that the test environment is clean and isolated for each execution.

Highlights

• Test Environment Stability: Replaced a hardcoded /tmp path in the Ollama pull test with a dynamically generated temporary directory, preventing PermissionError issues and ensuring test isolation.
• Resource Management: Ensured automatic cleanup of test-generated directories upon test completion by utilizing Python's tempfile.TemporaryDirectory().

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request resolves a test flakiness issue by replacing a hardcoded temporary directory with a dynamically generated one using tempfile.TemporaryDirectory. This change ensures that each test run has a unique, writable directory that is automatically cleaned up, preventing potential permission errors and side effects between tests. The implementation is correct and follows best practices for managing temporary resources in pytest fixtures. The changes are a solid improvement to the test suite's reliability.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[engelmi]

/packit rebuild-failed

[engelmi]

LGTM