use go v1.18 and update dependencies #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @jdef |
|
cc @saad-ali |
jdef
reviewed
Sep 30, 2022
go.mod
Outdated
| module github.com/container-storage-interface/spec | ||
|
|
||
| go 1.16 | ||
| go 1.19 |
There was a problem hiding this comment.
is this version actually required to build CSI (w/ reasonable deps)? if not, why not bump to 1.17 or 1.18 instead? CSI module doesn't need to be bleeding edge (and thereby force downstream users to use the latest Go)
There was a problem hiding this comment.
sure @jdef , I have declared it on 1.18 in the last refresh.
Signed-off-by: Humble Chirammal <[email protected]>
jdef
approved these changes
Oct 4, 2022
|
@saad-ali any opinions here? if not, i'll merge as is |
|
No objections. LGTM |
saad-ali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal [email protected]