Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,13 @@ message NodeGetVolumeStatsRequest {
// the process serving this request.
// This is a REQUIRED field.
string volume_path = 2;

// The path where the volume is staged, if the plugin has the
// STAGE_UNSTAGE_VOLUME capability, otherwise empty.
// If not empty, it MUST be an absolute path in the root
// filesystem of the process serving this request.
// This field is OPTIONAL.
string staging_path = 3;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this change!
If we want to remain consistent with other places this is used, its actually called: staging_target_path
eg:

spec/csi.proto

Line 1152 in 9e773d2

string staging_target_path = 3;

spec/csi.proto

Line 1129 in 9e773d2

string staging_target_path = 2;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestion, I have implemented it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was going to be renamed from staging_path to staging_target_path for consistency .. what happened?

}

message NodeGetVolumeStatsResponse {
Expand Down Expand Up @@ -1327,6 +1334,13 @@ message NodeExpandVolumeRequest {
// plugin MAY expand the volume to its maximum capacity.
// This field is OPTIONAL.
CapacityRange capacity_range = 3;

// The path where the volume is staged, if the plugin has the
// STAGE_UNSTAGE_VOLUME capability, otherwise empty.
// If not empty, it MUST be an absolute path in the root
// filesystem of the process serving this request.
// This field is OPTIONAL.
string staging_path = 4;
}

message NodeExpandVolumeResponse {
Expand Down
Loading