Skip to content

Clarify interaction between NodeExpandVolume and OFFLINE capability #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

Clarify interaction between NodeExpandVolume and OFFLINE capability #356

merged 1 commit into from
Mar 7, 2019

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Mar 6, 2019

jdef
jdef reviewed Mar 6, 2019
View reviewed changes
jdef
jdef approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnufied gnufied force-pushed the clarify-offline-node-expansion branch from 9a18531 to 051c781 Compare March 6, 2019 23:40
@gnufied
Copy link
Contributor Author

gnufied commented Mar 6, 2019

squashed the commits.

julian-hj
julian-hj approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@julian-hj julian-hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdef jdef merged commit 811bde6 into container-storage-interface:master Mar 7, 2019
@saad-ali
Copy link
Member

saad-ali commented Mar 7, 2019

Please make sure to cherry pick to release-1.1 branch

@gnufied gnufied mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdef jdef jdef approved these changes

+1 more reviewer

@julian-hj julian-hj julian-hj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnufied @saad-ali @jdef @julian-hj