Skip to content

Conversation

jdef
Copy link
Member

@jdef jdef commented Nov 13, 2018

The spec package name was recently changed to v1, providing us the
chance to properly number message fields starting from 1.

  • ControllerGetCapabilitiesResponse
  • GetPluginCapabilitiesResponse

The spec package name was recently changed to v1, providing us the
chance to properly number message fields starting from 1.

* ControllerGetCapabilitiesResponse
* GetPluginCapabilitiesResponse
@jdef jdef requested review from jieyu and saad-ali November 13, 2018 18:53
@saad-ali saad-ali added the breaking-change Breaks backwards compat label Nov 13, 2018
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, why didn't we do this originally?

lgtm
approve

Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdef jdef merged commit b44559b into container-storage-interface:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaks backwards compat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants