Skip to content

spec: Clarify target_path and staging_target_path #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

spec: Clarify target_path and staging_target_path #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,10 +939,13 @@ message NodeStageVolumeRequest {
// this capability. This is an OPTIONAL field.
map<string, string> publish_info = 2;

// The path to which the volume will be published. It MUST be an
// The path to which the volume MAY be staged. It MUST be an
// absolute path in the root filesystem of the process serving this
// request. The CO SHALL ensure that there is only one
// staging_target_path per volume.
// `staging_target_path` per volume. The CO SHALL ensure that the
// process serving the request has `read` and `write` permission to
// the path, and is able to create files or directories at the path
// if it does not exist.
// This is a REQUIRED field.
string staging_target_path = 3;

Expand All @@ -955,7 +958,7 @@ message NodeStageVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 5 [(csi_secret) = true];

// Attributes of the volume to publish. This field is OPTIONAL and
// Attributes of the volume to stage. This field is OPTIONAL and
// MUST match the attributes of the `Volume` identified by
// `volume_id`.
map<string, string> volume_attributes = 6;
Expand All @@ -968,7 +971,7 @@ message NodeUnstageVolumeRequest {
// The ID of the volume. This field is REQUIRED.
string volume_id = 1;

// The path at which the volume was published. It MUST be an absolute
// The path at which the volume was staged. It MUST be an absolute
// path in the root filesystem of the process serving this request.
// This is a REQUIRED field.
string staging_target_path = 2;
Expand All @@ -988,7 +991,7 @@ message NodePublishVolumeRequest {
// this capability. This is an OPTIONAL field.
map<string, string> publish_info = 2;

// The path to which the device was mounted by `NodeStageVolume`.
// The path to which the volume was staged by `NodeStageVolume`.
// It MUST be an absolute path in the root filesystem of the process
// serving this request.
// It MUST be set if the Node Plugin implements the
Expand All @@ -999,8 +1002,9 @@ message NodePublishVolumeRequest {
// The path to which the volume will be published. It MUST be an
// absolute path in the root filesystem of the process serving this
// request. The CO SHALL ensure uniqueness of target_path per volume.
// The CO SHALL ensure that the path exists, and that the process
// serving the request has `read` and `write` permissions to the path.
// The CO SHALL ensure that the process serving the request has
// `read` and `write` permissions to the path, and is able to create
// files or directories at the path if it does not exist.
// This is a REQUIRED field.
string target_path = 4;

Expand Down
Loading