Travis CI failing with undefined proto errors for trivial text change PR's

[davidz627]

For example this PR is just text change: #375

CI is failing here: https://travis-ci.org/container-storage-interface/spec/jobs/569485934

The error:

go install ./csi
# google.golang.org/genproto/googleapis/rpc/status
../../../../../google.golang.org/genproto/googleapis/rpc/status/status.pb.go:23:11: undefined: proto.ProtoPackageIsVersion3
make: *** [csi.a] Error 2
make: Leaving directory `/home/travis/gopath/src/github.com/container-storage-interface/spec/lib/go'

My assumption is one of the proto libraries/grpc version is unpinned in CI and the golang (and some other stuff) has pinned versioning. So just every once in a while CI will break for no reason.

This is an issue with the Spec. Generating the protos on a local machine isn't much better to be honest, it's always an exercise in figuring out the correct package versions to have on my workstation...

/assign @jdef @saad-ali @jieyu @julian-hj

[jieyu]

We really need to move to a docker based build environment.

[saad-ali]

We really need to move to a docker based build environment.

@hakanmemisoglu: It is asking a lot, but would you be interested and willing to do this?

[tdmanv]

@saad-ali Hakan is a bit swamped at the moment, but I have some time to help out. Do you have a preference for where to put the Dockerfile and upload an image? It looks like https://hub.docker.com/_/golang is almost enough to run the travis commands. The only thing missing is unzip

[tdmanv]

@saad-ali This instance of the issue is fixed by #378.

We can also help with containerizing the build environment, but we would need to discuss where to put the Dockerfile and host the image.

[saad-ali]

@tdmanv thank you very much, that would be great. Let's put it in https://quay.io/organization/k8scsi
If you share your quay username with me (feel free to email me, if you prefer), I can invite you to that org

[tdmanv]

@saad-ali I don't mind: https://quay.io/user/tdmanv

[saad-ali]

@tdmanv invite to the org sent! Feel free to create a new repo called csi-spec or spec or something for the image in that org. Thanks again. Also there are a bunch of scripts that the kubernetes-csi repo uses to push to quay, see https://github.com/kubernetes-csi/csi-release-tools (you may be able to barrow things from there).

[tdmanv]

Great thanks for the pointer.

My preference would be to first merge #378, which is required no matter what and will immediately unblock the other PRs. After I can followup with dockerizing the build. It requires makefile and travis changes so it will take a bit longer.

What do you think?

[saad-ali]

SGTM. Merged 378

[saad-ali]

@tdmanv can you and @hakanmemisoglu also make sure to sign the CLA. I also sent you an email with instructions.

[tdmanv]

Done! Thank you.