Skip to content

Add FeedbackingValueSource #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2024
Merged

Add FeedbackingValueSource #18

merged 1 commit into from
May 12, 2024

Conversation

errandir
Copy link
Contributor

No description provided.

@belingueres
Copy link
Contributor

Please open an issue explaining the value proposition of this PR.
Regards,
Gabriel

@errandir
Copy link
Contributor Author

The issue opened: #22

@slachiewicz slachiewicz requested a review from gnodet May 5, 2024 09:04
@slachiewicz
Copy link
Member

@gnodet can You check it?

gnodet
gnodet approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it's of low use on its own, it'll have to be leveraged in maven.
For maven 4, I was wondering about exposing an interpolation service in the V4 API though (it could leverage the plexus-interpolation as an implementation).

@slachiewicz slachiewicz merged commit c9ee543 into codehaus-plexus:master May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@errandir @belingueres @slachiewicz @gnodet