Fixed ConcurrentModificationException on a map and tweeked some options.

[MarcMazas]

No description provided.

[olamy]

Do you have a stack trace of the ConcurrentModificationException?

[MarcMazas]

I had one, but did not record it, pointing on the second call to it.next(), denoting the map change due to the put() on it; the proposed and tested fix is to use an additional map ca2. Le sam. 12 juil. 2025 à 11:17, Olivier Lamy ***@***.***> a écrit :

…

*olamy* left a comment (codehaus-plexus/plexus-compiler#443) <#443 (comment)> Do you have a stack trace of the ConcurrentModificationException? — Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQZRCZPKINQOZYDFJBRWVT3IDHBLAVCNFSM6AAAAACBDR3KUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRUHE4DANBTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MarcMazas]

I added a commit to fix erroneous excludes management.

[MarcMazas]

I do too but did not find a way to create a second pull request while the first one was still opened...

[MarcMazas]

Do you have a stack trace of the ConcurrentModificationException?

You should get one easily with:

                  <compilerArgs>
                    <arg>-nologo:true</arg>
                    <arg>-nowarn:0414</arg>
                    <arg>-utf8output:true</arg>
                    <arg>-target:exe</arg>
                    <arg>-out:${project.artifactId}.exe</arg>
                  </compilerArgs>

[Copilot]

Pull Request Overview

This PR fixes a ConcurrentModificationException that occurred when modifying a map while iterating over it, and includes several improvements to compiler argument handling and option tweaks for the C# compiler.

• Fixed ConcurrentModificationException by using a temporary HashMap to collect modifications during iteration
• Enhanced debug option handling to support different debug modes (full, pdbonly, etc.)
• Corrected various compiler argument processing logic and fixed a bug where excludes were incorrectly set as includes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Corrected spelling of 'no' to 'not'.

Suggested change

	// plugin parameter is no the same as the compiler option! so replaced
	// plugin parameter is not the same as the compiler option! so replaced

[Copilot]

[nitpick] Consider removing commented-out code rather than leaving it in the codebase. If this code might be needed for reference, document why it was removed in a comment.

Suggested change

	// plugin parameter is no the same as the compiler option! so replaced
	// if (config.isDebug()) {
	// args.add("/debug+");
	// } else {
	// args.add("/debug-");
	// }
	// plugin parameter is not the same as the compiler option, so debug handling was removed.

[Copilot]

[nitpick] Consider removing commented-out code rather than leaving it in the codebase.

Suggested change

// compilerArguments.put(k, v);