Skip to content

Avoid NPE in AspectJCompilerTest on AspectJ 1.9.8+ #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Avoid NPE in AspectJCompilerTest on AspectJ 1.9.8+ #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72d0b48
Bump aspectj.version from 1.9.7.M3 to 1.9.9.1
dependabot[bot] Jun 19, 2022
7cb33b3
Avoid NPE in AspectJCompilerTest on AspectJ 1.9.8+
kriegaex Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...exus-compiler-aspectj/src/main/java/org/codehaus/plexus/compiler/ajc/AspectJCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,10 @@ public AspectJMessagePrinter( boolean verbose )
private AjBuildConfig buildCompilerConfig( CompilerConfiguration config )
throws CompilerException
{
AjBuildConfig buildConfig = new AjBuildConfig(new BuildArgParser(new AspectJMessagePrinter(config.isVerbose())));
BuildArgParser buildArgParser = new BuildArgParser(new AspectJMessagePrinter(config.isVerbose()));
AjBuildConfig buildConfig = new AjBuildConfig(buildArgParser);
// Avoid NPE when AjBuildConfig.getCheckedClasspaths() is called later during compilation
buildArgParser.populateBuildConfig(buildConfig, new String[0], true, null);
buildConfig.setIncrementalMode( false );

String[] files = getSourceFiles( config );
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<project.build.outputTimestamp>2022-04-30T04:30:22Z</project.build.outputTimestamp>
<jupiter.version>5.8.2</jupiter.version>
<aspectj.version>1.9.7</aspectj.version>
<aspectj.version>1.9.9.1</aspectj.version>
<maven.version>3.2.5</maven.version>
<errorprone.version>2.14.0</errorprone.version>
<trimStackTrace>false</trimStackTrace>
Expand Down