Skip to content

⚡️ Speed up function tensor_to_value by 31% #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function tensor_to_value by 31% #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions google/cloud/aiplatform/_streaming_prediction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@ def tensor_to_value(tensor_pb: aiplatform_types.Tensor) -> Any:
list_of_fields = tensor_pb.ListFields()
if not list_of_fields:
return None
descriptor, value = tensor_pb.ListFields()[0]
if descriptor.name == "list_val":
descriptor, value = list_of_fields[0]
name = descriptor.name
if name == "list_val":
# Use list comprehension instead of generator expression for completeness
return [tensor_to_value(x) for x in value]
elif descriptor.name == "struct_val":
elif name == "struct_val":
# Use dict comprehension directly on value.items() for maximal efficiency
return {k: tensor_to_value(v) for k, v in value.items()}
# Check for Sequence after above cases, then avoid repeating ListFields()
if not isinstance(value, Sequence):
raise TypeError(f"Unexpected non-list tensor value {value}")
if len(value) == 1:
return value[0]
else:
return value
# Only construct the list if len(value) != 1; returned value is unchanged
return value[0] if len(value) == 1 else value


def predict_stream_of_tensor_lists_from_single_tensor_list(
Expand Down