Skip to content

⚡️ Speed up method _VertexRayClientContext._context_table_template by 456% #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method _VertexRayClientContext._context_table_template by 456% #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions google/cloud/aiplatform/vertex_ray/client_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,17 @@ def __init__(
self.shell_uri = ray_head_uris.get("RAY_HEAD_NODE_INTERACTIVE_SHELL_URI")

def _context_table_template(self):
cls = type(self)
if not hasattr(cls, "_shell_uri_template"):
cls._shell_uri_template = VertexRayTemplate("context_shellurirow.html.j2")
if not hasattr(cls, "_table_template"):
cls._table_template = VertexRayTemplate("context_table.html.j2")

shell_uri_row = None
if self.shell_uri is not None:
shell_uri_row = VertexRayTemplate("context_shellurirow.html.j2").render(
shell_uri=self.shell_uri
)
shell_uri_row = cls._shell_uri_template.render(shell_uri=self.shell_uri)

return VertexRayTemplate("context_table.html.j2").render(
return cls._table_template.render(
python_version=self.python_version,
ray_version=self.ray_version,
vertex_sdk_version=self.vertex_sdk_version,
Expand Down