Skip to content

⚡️ Speed up method PipelineRuntimeConfigBuilder._get_vertex_value by 2,895% #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method PipelineRuntimeConfigBuilder._get_vertex_value by 2,895% #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions google/cloud/aiplatform/utils/pipeline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ def __init__(
self._failure_policy = failure_policy
self._default_runtime = default_runtime

# Cache the version comparison to avoid repeated parsing
self._is_legacy_schema = packaging.version.parse(
self._schema_version
) <= packaging.version.parse("2.0.0")

@classmethod
def from_job_spec_json(
cls,
Expand Down Expand Up @@ -243,9 +248,7 @@ def _get_vertex_value(
"pipeline job input definitions.".format(name)
)

if packaging.version.parse(self._schema_version) <= packaging.version.parse(
"2.0.0"
):
if self._is_legacy_schema:
result = {}
if self._parameter_types[name] == "INT":
result["intValue"] = value
Expand Down