⚡️ Speed up method BaseModelAdminChecks._check_autocomplete_fields
by 7%
#495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 7% (0.07x) speedup for
BaseModelAdminChecks._check_autocomplete_fields
indjango/contrib/admin/checks.py
⏱️ Runtime :
2.54 milliseconds
→2.38 milliseconds
(best of154
runs)📝 Explanation and details
Optimization notes:
_check_autocomplete_fields
with a direct for loop for much better performance and memory efficiency (removes the creation of an intermediate list of results, and avoids the relatively expensivechain.from_iterable
). This is an especially big win because the vast majority of calls in typical Django admin usage result in[]
(which now will not allocate spurious empty lists).errors.append
asappend_error
for tight-loop micro-optimization (minor but relevant in hot paths)._check_autocomplete_fields_item
to avoid unnecessary code path indirections.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-BaseModelAdminChecks._check_autocomplete_fields-mgsqh7ce
and push.