Skip to content

Problem with ScreenCompare with Playwright #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Problem with ScreenCompare with Playwright #113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66b0afe
+Update resemblejs
tfr-ds May 31, 2022
4443e48
+Fix bug for element diff
tfr-ds May 31, 2022
7c3d7a5
+Update package versions
tfr-ds Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ class ResembleHelper extends Helper {
await this._download(awsC.accessKeyId, awsC.secretAccessKey, awsC.region, awsC.bucketName, baseImage, options);
}

if (selector) {
// BoundingBox for Playwright not necessary
if (selector && !this.helpers['Playwright']) {
options.boundingBox = await this._getBoundingBox(selector);
}
const misMatch = await this._fetchMisMatchPercentage(baseImage, options);
Expand Down