fix: adjust selector registration strategy to avoid false warnings in console #5243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Since the last update, there are warnings in the console during the set-up of helper Playwright.
I tried to investigate it may come from the following change #5090
Actually, the
_init
method is called twice (causing warning) and I guess there is a concurrent run. I think it's because of this call:CodeceptJS/lib/helper/Playwright.js
Lines 363 to 366 in bed491f
Note: this is a new behaviour has been introduced in the version 3.7.5 - version 3.7.4 called only once the
_init
methodThis PR doesn't fix the root cause, but prevent user to receive confused message when they run tests.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)