fix: retryFailedStep plugin works in debug/verbose mode #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove debugMode check that prevented retries when --verbose or --debug flags are used - Fix affects both retryFailedStep and enhancedRetryFailedStep plugins - Add regression test to ensure retries work correctly in debug mode - Resolves issue where plugin was disabled in debug mode without clear reason Fixes codeceptjs#4384
mirao
commented
Sep 2, 2025
|
|
||
| const when = err => { | ||
| if (!enableRetry) return false | ||
| if (store.debugMode) return false |
There was a problem hiding this comment.
Not sure if the fix is needed here too, because enhancedRetryFailedStep plugin seems the quite hot new feature: #5103
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the retryFailedStep and enhancedRetryFailedStep plugins were disabled when running CodeceptJS with --verbose or --debug flags. The fix removes the debugMode check that prevented retries from working in debug mode.
- Removes
if (store.debugMode) return falsecheck from both retry plugins - Adds regression test to verify retries work correctly when debugMode is enabled
- Ensures retry functionality is available regardless of debug/verbose mode settings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/plugin/retryFailedStep.js | Removes debugMode check that blocked retries in debug mode |
| lib/plugin/enhancedRetryFailedStep.js | Removes debugMode check that blocked retries in debug mode |
| test/unit/plugin/retryFailedStep_test.js | Adds regression test to ensure retries work in debug mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by VSCode Copilot with Claude Sonnet 4.
Personally I checked that the added unit test fails as expected before the fix.
Motivation/Description of the PR
Fixes #4384
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)