Skip to content

Fixup WikipediaLoader #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Draft

Fixup WikipediaLoader #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
027aff9
FIXME
bpkroth Dec 13, 2023
bf2852c
Merge branch 'main' into fix-wikipedia-cockroackdb-limits
bpkroth Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/oltpbenchmark/benchmarks/wikipedia/WikipediaLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,9 @@ private void loadRevision(Connection conn) throws SQLException {
int old_text_length = h_textLength.nextValue();
char[] old_text = TextGenerator.randomChars(rng(), old_text_length);

// FIXME: Need to break up the num_revised into multiple batches to avoid
// packet size limits in loader.
// See Also: #405
for (int i = 0; i < num_revised; i++) {
// Generate the User who's doing the revision and the Page revised
// Makes sure that we always update their counter
Expand Down