Fix carrierwave 1.0 support #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@razorjack Sorry for the delayed response, but thank you very much for this! 🍻 |
This was referenced Oct 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all tests so that the gem can now support CarrierWave 1.0.
CarrierWave 1.0 changed the way it deals with replaced files (determining if the original file should be deleted) so I needed to overwrite
remove_previously_stored_#{column}to support it. I also modified how we changeremove_previously_stored_files_after_updateconfig in tests to match the ActiveRecord equivalent. CarrierWave 1.0 checks this config on the uploader class, not instance.The tests will fail for old versions of CarrierWave (
_mounter(column).uploadervs_mounter(column).uploaders).If there's anything I can help you with to get the CarrierWave 1.0 support out, let me know, I'll be happy to help.