Skip to content

Custom hooks seem broken in devenv v1. #427

@bjgbeelen

Description

@bjgbeelen

When upgrading from devenv 0.6.3 to 1.0.3 I run into the issue that my custom hooks result in errors.

It smallest possible reproduction is the following.

  • created a new devenv using devenv init
  • added a custom hook:
pre-commit.hooks = {
    foo = {
      enable = true;
      entry = "echo foo";
    };
  };

this results in the following error:

error:
       error: The option `pre-commit.hooks.foo.package' is used but not defined.
My devenv.lock file
{
  "nodes": {
    "devenv": {
      "locked": {
        "dir": "src/modules",
        "lastModified": 1712560659,
        "owner": "cachix",
        "repo": "devenv",
        "rev": "dce1b9c775f6dcce528c41cb2b989ab322981c17",
        "treeHash": "576fd153ebc87e5de4ecb68e70cde88a22002ed4",
        "type": "github"
      },
      "original": {
        "dir": "src/modules",
        "owner": "cachix",
        "repo": "devenv",
        "type": "github"
      }
    },
    "flake-compat": {
      "flake": false,
      "locked": {
        "lastModified": 1696426674,
        "owner": "edolstra",
        "repo": "flake-compat",
        "rev": "0f9255e01c2351cc7d116c072cb317785dd33b33",
        "treeHash": "2addb7b71a20a25ea74feeaf5c2f6a6b30898ecb",
        "type": "github"
      },
      "original": {
        "owner": "edolstra",
        "repo": "flake-compat",
        "type": "github"
      }
    },
    "flake-utils": {
      "inputs": {
        "systems": "systems"
      },
      "locked": {
        "lastModified": 1710146030,
        "owner": "numtide",
        "repo": "flake-utils",
        "rev": "b1d9ab70662946ef0850d488da1c9019f3a9752a",
        "treeHash": "bd263f021e345cb4a39d80c126ab650bebc3c10c",
        "type": "github"
      },
      "original": {
        "owner": "numtide",
        "repo": "flake-utils",
        "type": "github"
      }
    },
    "gitignore": {
      "inputs": {
        "nixpkgs": [
          "pre-commit-hooks",
          "nixpkgs"
        ]
      },
      "locked": {
        "lastModified": 1709087332,
        "owner": "hercules-ci",
        "repo": "gitignore.nix",
        "rev": "637db329424fd7e46cf4185293b9cc8c88c95394",
        "treeHash": "ca14199cabdfe1a06a7b1654c76ed49100a689f9",
        "type": "github"
      },
      "original": {
        "owner": "hercules-ci",
        "repo": "gitignore.nix",
        "type": "github"
      }
    },
    "nixpkgs": {
      "locked": {
        "lastModified": 1710796454,
        "owner": "cachix",
        "repo": "devenv-nixpkgs",
        "rev": "06fb0f1c643aee3ae6838dda3b37ef0abc3c763b",
        "treeHash": "9bb13f7f39e825a5d91bbe4139fbc129243b907d",
        "type": "github"
      },
      "original": {
        "owner": "cachix",
        "ref": "rolling",
        "repo": "devenv-nixpkgs",
        "type": "github"
      }
    },
    "nixpkgs-stable": {
      "locked": {
        "lastModified": 1712437997,
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "e38d7cb66ea4f7a0eb6681920615dfcc30fc2920",
        "treeHash": "ea31ce141ad288a6be1e183297370fcd631e949d",
        "type": "github"
      },
      "original": {
        "owner": "NixOS",
        "ref": "nixos-23.11",
        "repo": "nixpkgs",
        "type": "github"
      }
    },
    "pre-commit-hooks": {
      "inputs": {
        "flake-compat": "flake-compat",
        "flake-utils": "flake-utils",
        "gitignore": "gitignore",
        "nixpkgs": [
          "nixpkgs"
        ],
        "nixpkgs-stable": "nixpkgs-stable"
      },
      "locked": {
        "lastModified": 1712055707,
        "owner": "cachix",
        "repo": "pre-commit-hooks.nix",
        "rev": "e35aed5fda3cc79f88ed7f1795021e559582093a",
        "treeHash": "41bee5f5bd9314a987ef3d7cba730fb6aa264a4e",
        "type": "github"
      },
      "original": {
        "owner": "cachix",
        "repo": "pre-commit-hooks.nix",
        "type": "github"
      }
    },
    "root": {
      "inputs": {
        "devenv": "devenv",
        "nixpkgs": "nixpkgs",
        "pre-commit-hooks": "pre-commit-hooks"
      }
    },
    "systems": {
      "locked": {
        "lastModified": 1681028828,
        "owner": "nix-systems",
        "repo": "default",
        "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e",
        "treeHash": "cce81f2a0f0743b2eb61bc2eb6c7adbe2f2c6beb",
        "type": "github"
      },
      "original": {
        "owner": "nix-systems",
        "repo": "default",
        "type": "github"
      }
    }
  },
  "root": "root",
  "version": 7
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions