Skip to content

add ref doc and extract a couple vars and skip a sqrt in shadow cascades #20361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025
Merged

add ref doc and extract a couple vars and skip a sqrt in shadow cascades #20361

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9af9b6
add ref doc and extract a couple vars and skip a sqrt
atlv24 Jul 31, 2025
ea7207f
Update crates/bevy_light/src/cascade.rs
atlv24 Aug 1, 2025
1260241
Update crates/bevy_light/src/cascade.rs
atlv24 Aug 1, 2025
a0c1c4d
Doc wording
james7132 Aug 4, 2025
0d26461
Merge branch 'main' into ad/cascade-3
james7132 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/bevy_light/src/cascade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,8 @@ pub fn build_directional_light_cascades(
///
/// The corner vertices should be specified in the following order:
/// first the bottom right, top right, top left, bottom left for the near plane, then similar for the far plane.
///
/// See this [reference](https://developer.download.nvidia.com/SDK/10.5/opengl/src/cascaded_shadow_maps/doc/cascaded_shadow_maps.pdf) for more details.
fn calculate_cascade(
frustum_corners: [Vec3A; 8],
cascade_texture_size: f32,
Expand All @@ -284,10 +286,9 @@ fn calculate_cascade(
// as even though the lengths using corner_light_view above should be the same, precision can
// introduce small but significant differences.
// NOTE: The size remains the same unless the view frustum or cascade configuration is modified.
let cascade_diameter = (frustum_corners[0] - frustum_corners[6])
.length()
.max((frustum_corners[4] - frustum_corners[6]).length())
.ceil();
let body_diagonal = (frustum_corners[0] - frustum_corners[6]).length_squared();
let far_plane_diagonal = (frustum_corners[4] - frustum_corners[6]).length_squared();
let cascade_diameter = body_diagonal.max(far_plane_diagonal).sqrt().ceil();

// NOTE: If we ensure that cascade_texture_size is a power of 2, then as we made cascade_diameter an
// integer, cascade_texel_size is then an integer multiple of a power of 2 and can be
Expand Down
Loading