Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Implements #12461.
Solution
Makes
RenderLayers
no longer a component, adds componentsVisibleLayers
andInheritedVisibleLayers
that work as you'd expect, andVisibleLayers
is now required byVisibility
.Testing
These changes work on all of the examples that used to use
RenderLayers
as a component:pixel_grid_snap
,first_person_view_model
,order_independent_transparency
, andrender_to_texture
. I have yet to do any benchmarking. It also seems to work in the more hierarchical example I put in showcase.Showcase
Users can now add
VisibleLayers
to a root component of a mesh, and it will inherit down the tree!Click to view showcase
Migration Guide
RenderLayers
as a component withVisibleLayers
.