Update HitData position docs
#17833
Merged
Update HitData position docs
#17833
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 13, 2025
|
@notmd, how's this? |
alice-i-cecile
added
C-Docs
notmd
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
This is much more clear. Maybe we can add which space is used in each backend/plugin? About the normalize value for UI, I think we should use the non normalized value instead. In web it is https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/offsetX which use quite often. The normalized value can easily be computed from non normalized one.
|
Normalized values of the clicks in UI is quite helpful for building widgets, while non-normalized value is usually just the mouse position 🤔 That's for a different thread though; maybe spin up an issue? |
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Updates the now inaccurate position docs
Fixes #17832
Solution
From
The position of the intersection in the world, if the data is available from the backend.To
The position reported by the backend, if the data is available. Position data may be in any space (e.g. World space, Screen space, Local space), specified by the backend providing it.Testing
uhh reading :)