Improve error message when flags are positioned after positional arguments #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments When -exec or other flags are placed after DB_PATH and REPLICA_URL arguments, provide a clear error message instead of the confusing "replica url scheme required" error. Fixes #245 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Tests verify that flags positioned after positional arguments produce clear error messages instead of confusing URL scheme errors. Covers various scenarios: - -exec flag after positional args (issue #245 scenario) - -config flag after positional args - Multiple flags in correct positions - Edge cases with missing replica URLs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
benbjohnson
approved these changes
Sep 8, 2025
Comment on lines
82
to
85
| // Check if this looks like a flag that was placed after positional arguments | ||
| if len(u) > 0 && u[0] == '-' { | ||
| return fmt.Errorf("flag %q must be positioned before DB_PATH and REPLICA_URL arguments", u) | ||
| } |
There was a problem hiding this comment.
strings.HasPrefix(u, "-") is probably a little more idiomatic
Per PR review feedback, replace manual character checking with strings.HasPrefix() for detecting flags placed after positional arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-execflag positioned after positional arguments produced a confusing error messageTest plan
🤖 Generated with Claude Code