Fix: standardize error message prefixes across all replica clients #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit standardizes error message prefixes across all storage backend replica clients for consistency and better debugging experience. Changes: - Google Storage (gs): Added "gs:" prefix to 2 error messages - SFTP: Added "sftp:" prefix to 9 error messages - S3: Added "s3:" prefix to 11 error messages Benefits: - Consistent error formatting across all storage backends - Easier identification of which storage backend produces errors in logs - Better debugging experience for users Closes #710 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
benbjohnson
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes error message prefixes across all storage backend replica clients for consistency and better debugging experience, as suggested in issue #710.
Changes Made
Google Storage Client (
gs/replica_client.go)gs:prefix to 2 error messagesSFTP Client (
sftp/replica_client.go)sftp:prefix to 9 error messagesS3 Client (
s3/replica_client.go)s3:prefix to 11 error messages (some already had the prefix)File Client (
file/replica_client.go)Benefits
Examples
Before:
After:
Test Results
go test ./...)go vet ./...)staticcheck ./...)Closes #710
🤖 Generated with Claude Code