Add tests to verify TXID parsing uses ltx.ParseTXID #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive tests for txidVar type - Verify proper hex TXID parsing and validation - Confirm invalid inputs are properly rejected This verifies that issue benbjohnson#673 is already correctly implemented. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
corylanou
force-pushed
the
fix-673-txid-parsing
branch
from
5cbedc1 to
445a5ed
Compare
benbjohnson
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive tests to verify that TXID parsing in CLI commands correctly uses
ltx.ParseTXID, addressing issue #673.Investigation Results
After thorough investigation of the codebase, I found that TXID parsing is already correctly implemented:
txidVartype incmd/litestream/main.go(lines 812-831) properly implements TXID parsing usingltx.ParseTXIDrestorecommand is the only CLI command that accepts TXID arguments via the-txidflagtxidVartype, ensuring consistent use ofltx.ParseTXIDChanges
cmd/litestream/txid_parsing_test.gowith comprehensive tests for thetxidVartypeTest Coverage
The tests verify:
Test Results
=== RUN TestTXIDVarParsing === RUN TestTXIDVarParsing/valid_hex_string === RUN TestTXIDVarParsing/valid_hex_string_with_letters === RUN TestTXIDVarParsing/uppercase_hex === RUN TestTXIDVarParsing/invalid_-_too_short === RUN TestTXIDVarParsing/invalid_-_too_long === RUN TestTXIDVarParsing/invalid_-_non-hex_characters --- PASS: TestTXIDVarParsing (0.00s) --- PASS: TestTXIDVarParsing/valid_hex_string (0.00s) --- PASS: TestTXIDVarParsing/valid_hex_string_with_letters (0.00s) --- PASS: TestTXIDVarParsing/uppercase_hex (0.00s) --- PASS: TestTXIDVarParsing/invalid_-_too_short (0.00s) --- PASS: TestTXIDVarParsing/invalid_-_too_long (0.00s) --- PASS: TestTXIDVarParsing/invalid_-_non-hex_characters (0.00s) === RUN TestTXIDVarString === RUN TestTXIDVarString/zero === RUN TestTXIDVarString/small_number === RUN TestTXIDVarString/larger_number === RUN TestTXIDVarString/max_value --- PASS: TestTXIDVarString (0.00s) --- PASS: TestTXIDVarString/zero (0.00s) --- PASS: TestTXIDVarString/small_number (0.00s) --- PASS: TestTXIDVarString/larger_number (0.00s) --- PASS: TestTXIDVarString/max_value (0.00s) PASSConclusion
No code changes were needed - the implementation already correctly uses
ltx.ParseTXIDfor all TXID parsing. This PR adds tests to ensure this behavior is maintained and to prevent regression.Fixes #673
🤖 Generated with Claude Code