-
Notifications
You must be signed in to change notification settings - Fork 310
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation
Description
Overview
After PR #732 is merged and tested, we should remove the old Makefile dist targets that are replaced by GoReleaser.
Blocked by: #732 (must be merged and tested first)
Targets to Remove
From Makefile
, remove these deprecated targets:
Lines to Remove
dist-linux
target (lines 6-11)dist-linux-arm
target (lines 12-14)dist-linux-arm64
target (lines 15-17)dist-macos
target (lines 18-33)- Related
.PHONY
declarations for these targets
Keep These
- ✅ Keep
docker
target - still useful for Docker builds - ✅ Keep
vfs
target - specific VFS functionality - ✅ Keep
clean
target - general utility - ✅ Keep
mcp-*
targets - MCP functionality
Testing Before Removal
Before removing these targets, ensure:
- At least one successful release has been made with GoReleaser
- Binaries from GoReleaser work correctly on all platforms
- Homebrew formula updates are working
- Team is comfortable with new release process
Why Remove?
- Eliminates confusion about which method to use
- Reduces maintenance burden
- Single source of truth for releases
- Makefile becomes cleaner and focused on development tasks
Migration Guide
Old command → New command:
make dist-linux
→goreleaser build --snapshot --single-target
make dist-macos
→goreleaser build --snapshot --single-target
LITESTREAM_VERSION=v0.3.14 make dist-macos
→git tag v0.3.14 && git push --tags
Implementation
Once ready to remove:
- Delete the dist-* targets from Makefile
- Update any documentation that references these commands
- Update CLAUDE.md to remove references to old commands
- Notify team of the change
Related Issues
- feat: Implement GoReleaser for automated releases with binary signing #732 - GoReleaser implementation (must be completed first)
- Set up code signing certificates for automated releases #733 - Certificate setup for signing
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation