updowngrade: better prepare riak.conf & caps, make it work for 1.4-1.5 and 1.5-1.6 cycles #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make code version-agnostic, only require newly introduced keys and caps to be registered when stepping to next release up/downgrade cycle.
macintux
reviewed
Mar 3, 2017
tests/ts_updown_util.erl
Outdated
| unknown -> | ||
| ct:fail("Failed to determine riak version in '~s' slot", [VsnSlot]); | ||
| Known -> | ||
| case re:run(Known, "riak_ts-(\\d+)\.(\\d+)\.(\\d+)", [{capture, all_but_first, list}]) of |
|
Other than the regular expression comment, this looks really good. |
|
+1 |
1 similar comment
|
+1 |
macintux
deleted the
fix-az-make_updowngrade_work_for_any_recent_versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTS-1661?
Make code version-agnostic, only require newly introduced keys and caps (those that we need to wait_until before actually performing the tests) to be registered when stepping to next release up/downgrade cycle. This should reduce the patch size when upgrading the updowngrade machinery for the next cycle.