Skip to content

fix missing AccountIDEndpointMode binding #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix missing AccountIDEndpointMode binding #3013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1989f49
fix missing accountid endpoint mode binding
lucix-aws Feb 17, 2025
6a9340c
changelog
lucix-aws Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .changelog/3BE795A2-340F-4D5A-B237-8CE604BCB8E9.json
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions .changelog/470a22d1d8304095b12f990c45e9f951.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "470a22d1-d830-4095-b12f-990c45e9f951",
"type": "bugfix",
"description": "Add missing AccountIDEndpointMode binding to endpoint resolution.",
"modules": [
"service/dynamodb"
]
}
10 changes: 0 additions & 10 deletions .changelog/adfe779a-b5b4-44bd-8e23-5cdb4db5aef8.json
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...rc/main/java/software/amazon/smithy/aws/go/codegen/customization/AwsEndpointBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ public class AwsEndpointBuiltins implements GoIntegration {
goTemplate("$T(options.DisableMultiRegionAccessPoints)", SdkGoTypes.Aws.Bool);
private static final GoWriter.Writable BindAccountID =
goTemplate("resolveAccountID(getIdentity(ctx), options.AccountIDEndpointMode)");
private static final GoWriter.Writable BindAccountIDEndpointMode =
goTemplate("$T(string(options.AccountIDEndpointMode))", SdkGoTypes.Aws.String);

@Override
public List<RuntimeClientPlugin> getClientPlugins() {
Expand All @@ -55,6 +57,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
.addEndpointBuiltinBinding("AWS::S3::DisableMultiRegionAccessPoints", BindAwsS3DisableMultiRegionAccessPoints)
.addEndpointBuiltinBinding("AWS::S3Control::UseArnRegion", BindAwsS3UseArnRegion)
.addEndpointBuiltinBinding("AWS::Auth::AccountId", BindAccountID)
.addEndpointBuiltinBinding("AWS::Auth::AccountIdEndpointMode", BindAccountIDEndpointMode)
.build());
}

Expand Down
1 change: 1 addition & 0 deletions service/dynamodb/endpoints.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.