-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(ecr): allow fromLookup
method to return dummy repository without error if target repository was not found
#34030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather have a new lookup function that returns
IRepository | undefined
.That new lookup function would also be a perfect place to attach disclaimers that I'm 99% sure most users will not expect, such as:
synth
. Therefore:I'm sure there's more that I can't think of right now.
Are we 100% confident offering this feature will lead to a good user experience? Because I'm concerned it will end up being a footgun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... You have a point, maybe we can't be 100% sure...
I'll drop this PR for now. If I get another good idea I might reopen it.