Skip to content

fix: Metrics e2e tests #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

fix: Metrics e2e tests #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef48a94
fix(tests): correct command in e2e-tests.yml and remove unnecessary a…
hjgraca Mar 3, 2025
7a0e0d9
Merge branch 'develop' into fix/metrics-e2e-tests
hjgraca Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,5 +212,5 @@ jobs:
- name: Destroy arm64 AOT Stack
run: |
cd libraries/tests/e2e/infra-aot
npox cdk destroy --all -c architecture=${{ matrix.arch }} --force
npx cdk destroy --all -c architecture=${{ matrix.arch }} --force

4 changes: 0 additions & 4 deletions libraries/tests/e2e/functions/core/metrics/Function/test/Function.Tests/FunctionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,10 @@ private void AssertSingleMetric(string output)

Assert.True(cloudWatchMetricsElement[0].TryGetProperty("Dimensions", out JsonElement dimensionsElement));
Assert.Equal("FunctionName", dimensionsElement[0][0].GetString());
Assert.Equal("Service", dimensionsElement[0][1].GetString());

Assert.True(root.TryGetProperty("FunctionName", out JsonElement functionNameElement));
Assert.Equal(_functionName, functionNameElement.GetString());

Assert.True(root.TryGetProperty("Service", out JsonElement serviceElement));
Assert.Equal("Test", serviceElement.GetString());

Assert.True(root.TryGetProperty("SingleMetric", out JsonElement singleMetricElement));
Assert.Equal(1, singleMetricElement.GetInt32());
}
Expand Down
Loading