Skip to content

Fix UB due to iterator reaching before begin() in rich header parsing #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fix UB due to iterator reaching before begin() in rich header parsing #987

merged 2 commits into from
Jul 15, 2021

Conversation

HoundThe
Copy link
Member

There was an undefined behavior because iterator pointing to begin() got decremented when the rich header parsing loop ends.

@PeterMatula PeterMatula self-requested a review July 15, 2021 12:48
PeterMatula
PeterMatula reviewed Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@PeterMatula PeterMatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok, but (reverse) iterators are tricky, so please give it a second look based on my comments.

@PeterMatula PeterMatula merged commit a2a4226 into avast:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMatula PeterMatula PeterMatula left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoundThe @PeterMatula