fix!: Prevent misconfiguration of the secret used with the HS*** algorithms #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rithms Added checks to make sure that a valid secret is used with the HS*** algorithms when signing and verifying BREAKING CHANGE: Requires node 12.x or later to allow use of `KeyObject`
|
Closed in favour of #852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added checks to make sure that a valid secret is used with the HS*** algorithms when signing and verifying
BREAKING CHANGE: Requires node 12.x or later to allow use of
KeyObjectTesting
All automated tests pass
Checked via script that this type of misconfiguration does not pass signing or verification
This change adds test coverage for new/changed/fixed functionality
Checklist
master