Skip to content

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 28, 2025

Description

Parameter deprecation https://github.com/oras-project/oras/releases

How Has This Been Tested?

  • Run manual test

Checklist:

  • My changes generate no new warnings

@igorpecovnik igorpecovnik requested a review from a team as a code owner September 28, 2025 04:15
Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

Walkthrough

The change modifies three functions in lib/functions/general/oci-oras.sh by updating the initialization of the extra_params array. In oras_push_artifact_file, oras_get_artifact_manifest, and oras_pull_artifact_file, extra_params is changed from being initialized with "--verbose" to an empty array (). No other logic in these functions is altered; later extensions of extra_params remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately summarizes the key change of deprecating the verbose flag in ORAS tools by noting that verbosity is now default as of v1.3, directly reflecting the modifications in the shell functions and providing clear context for reviewers.
Description Check ✅ Passed The description relates directly to the change by referencing the deprecation of the verbose parameter and linking to the ORAS release notes, confirming its relevance to the modifications.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch orasfix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eebef46 and 421e963.

📒 Files selected for processing (1)
  • lib/functions/general/oci-oras.sh (3 hunks)
🔇 Additional comments (3)
lib/functions/general/oci-oras.sh (3)

129-133: Drop deprecated --verbose flag

Removing the default verbose parameter keeps the call compatible with ORAS ≥1.3 and stops the deprecation warning, while the helper routines still append any required flags.


157-160: Consistent cleanup for manifest fetch

Same rationale here—matching the new default verbosity avoids the deprecated flag without altering downstream behavior.


182-185: Align pull path with new verbosity default

With verbosity now implicit in ORAS ≥1.3, this keeps the pull path free of deprecated options yet preserves dynamic flag injection.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Framework Framework components size/small PR with less then 50 lines 11 Milestone: Fourth quarter release labels Sep 28, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 28, 2025
@igorpecovnik igorpecovnik merged commit 68a98a6 into main Sep 28, 2025
12 checks passed
@igorpecovnik igorpecovnik deleted the orasfix branch September 28, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

1 participant